Convert and internalize MountingManager#51872
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76126338 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76126338 |
cortinico
force-pushed
the
export-D76126338
branch
from
0994147 to
f5dfa6a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76126338 |
cortinico
force-pushed
the
export-D76126338
branch
from
f5dfa6a to
f723e02
Compare
Summary: Pull Request resolved: facebook#51872 This converts to Kotlin and internaline MountingManager. The only usage in OSS is react-natve-live-markdown: Expensify/react-native-live-markdown#693 They're using reflection to access Mounting Manager, which they shouldn't. Other than them, I wasn't able to find meaningful usages of `MountingManager` Changelog: [Android] [Breaking] - Convert to Kotlin and internalize MountingManager Reviewed By: rshest Differential Revision: D76126338
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76126338 |
cortinico
force-pushed
the
export-D76126338
branch
from
f723e02 to
fe13651
Compare
Contributor
|
This pull request has been merged in f33fdca. |
Collaborator
|
This pull request was successfully merged by @cortinico in f33fdca When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This converts to Kotlin and internaline MountingManager.
The only usage in OSS is react-natve-live-markdown:
Expensify/react-native-live-markdown#693
They're using reflection to access Mounting Manager, which they shouldn't.
Other than them, I wasn't able to find meaningful usages of
MountingManagerChangelog:
[Android] [Breaking] - Convert to Kotlin and internalize MountingManager
Reviewed By: rshest
Differential Revision: D76126338