Skip to content

Update the transform not to rename member expression fragments #51891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
j-piasecki wants to merge 1 commit into from
Closed

Update the transform not to rename member expression fragments #51891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions scripts/build-types/transforms/__tests__/renameDefaultExportedIdentifiers-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,11 @@ describe('renameDefaultExportedIdentifiers', () => {

test('should rename local class name which is default-exported', async () => {
const code = `
class ExportedClass {};
class ExportedClass {}
export default ExportedClass;`;
const result = await translate(code);
expect(result).toMatchInlineSnapshot(`
"class ExportedClass_default {}
;
export default ExportedClass_default;"
`);
});
Expand All @@ -70,13 +69,27 @@ describe('renameDefaultExportedIdentifiers', () => {

test('should rename local function name which is default-exported', async () => {
const code = `
function exportedFunction() {};
function exportedFunction() {}
export default exportedFunction;`;
const result = await translate(code);
expect(result).toMatchInlineSnapshot(`
"function exportedFunction_default() {}
;
export default exportedFunction_default;"
`);
});

test('should not rename identifiers with the same name in member expressions', async () => {
const code = `
import Other from 'Other';
type Type = typeof Other.Exported;
class Exported {}
export default Exported;`;
const result = await translate(code);
expect(result).toMatchInlineSnapshot(`
"import Other from 'Other';
type Type = typeof Other.Exported;
class Exported_default {}
export default Exported_default;"
`);
});
});
7 changes: 6 additions & 1 deletion scripts/build-types/transforms/renameDefaultExportedIdentifiers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,12 @@ const visitor: PluginObj<mixed> = {
const newName = `${localSymbol}_default`;
nodePath.traverse({
Identifier(innerPath) {
if (innerPath.node.name === localSymbol) {
if (
innerPath.node.name === localSymbol &&
!innerPath.findParent(
path => t.isMemberExpression(path) || t.isTSQualifiedName(path),
)
) {
innerPath.node.name = newName;
}
},
Expand Down
Loading