Remove JSC related files from the repo #51945
Conversation
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76419587 |
|
This pull request was exported from Phabricator. Differential Revision: D76419587 |
Summary: Pull Request resolved: facebook#51945 Remove code from jsc folder from React Native ## Changelog: [iOS][Removed] - Remove code from jsc folder from React Native Differential Revision: D76419587
cipolleschi
force-pushed
the
export-D76419587
branch
from
4568517 to
dd7f3bd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76419587 |
Summary: Pull Request resolved: facebook#51945 Remove code from jsc folder from React Native ## Changelog: [iOS][Removed] - Remove code from jsc folder from React Native Differential Revision: D76419587
cipolleschi
force-pushed
the
export-D76419587
branch
from
dd7f3bd to
57337c8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76419587 |
Summary: Pull Request resolved: facebook#51945 Remove code from jsc folder from React Native ## Changelog: [iOS][Removed] - Remove code from jsc folder from React Native Differential Revision: D76419587
cipolleschi
force-pushed
the
export-D76419587
branch
from
57337c8 to
642252a
Compare
okwasniewski
left a comment
okwasniewski
left a comment
There was a problem hiding this comment.
Looks good, left couple of comments. I'll try to integrate it with community JSC once this gets merged and released in nightly
| throw std::runtime_error("No JSExecutorFactory specified."); | ||
| return nullptr; |
There was a problem hiding this comment.
Shouldn't we keep this error? Might be useful when users don't override the delegate method
| #elif USE_THIRD_PARTY_JSC != 1 | ||
| return jsrt_create_jsc_factory(); | ||
| #else | ||
| return nullptr; |
There was a problem hiding this comment.
Not sure but I think we need to return nullptr in the else case
| else | ||
| s.dependency "hermes-engine" | ||
| add_dependency(s, "React-RuntimeHermes") | ||
| s.exclude_files = "RCTJscInstanceFactory.{h,mm}" |
There was a problem hiding this comment.
This can be removed, right? We won't have this file
|
This pull request was exported from Phabricator. Differential Revision: D76419587 |
Summary: Pull Request resolved: facebook#51945 Remove code from jsc folder from React Native ## Changelog: [iOS][Removed] - Remove code from jsc folder from React Native Differential Revision: D76419587
cipolleschi
force-pushed
the
export-D76419587
branch
from
642252a to
5843a83
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76419587 |
cipolleschi
force-pushed
the
export-D76419587
branch
from
5843a83 to
9659dbb
Compare
Summary: Pull Request resolved: facebook#51945 Remove code from jsc folder from React Native ## Changelog: [iOS][Removed] - Remove code from jsc folder from React Native Reviewed By: rshest Differential Revision: D76419587
Summary: Pull Request resolved: facebook#51945 Remove code from jsc folder from React Native ## Changelog: [iOS][Removed] - Remove code from jsc folder from React Native Reviewed By: rshest Differential Revision: D76419587
|
This pull request was exported from Phabricator. Differential Revision: D76419587 |
cipolleschi
force-pushed
the
export-D76419587
branch
from
9659dbb to
6abac1c
Compare
|
This pull request was successfully merged by @cipolleschi in 331fab0 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 331fab0. |
4 participants
Summary:
Remove code from jsc folder from React Native
Changelog:
[iOS][Removed] - Remove code from jsc folder from React Native
Differential Revision: D76419587