Enable Defines Module option for RCTImage pod#51974
Closed
kkafar wants to merge 1 commit into
Closed
Conversation
This is to enable consuming this pod in mixed ObjC/Swift codebase. W/o this option set I get following error when building the library: ``` Installing RNScreens 4.11.1 [!] The following Swift pods cannot yet be integrated as static libraries: The Swift pod `RNScreens` depends upon `React-RCTImage`, which does not define modules. To opt into those targets generating module maps (which is necessary to import them from Swift when building as static libraries), you may set `use_modular_headers!` globally in your Podfile, or specify `:modular_headers => true` for particular dependencies. ``` I've noticed that there is also a precedent in the form of facebook@c8fcac2, which handled very simlar case but for `React-jsc` pod.
facebook-github-bot
added
CLA Signed
cipolleschi
approved these changes
Jun 12, 2025
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks for fixing this
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in 1d80586. |
Collaborator
|
This pull request was successfully merged by @kkafar in 1d80586 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is to enable consuming RCTImage pod in mixed ObjC/Swift codebase. W/o this option set I get following error when building the library:
I've noticed that there is also a precedent in the form of c8fcac2, which handled very simlar case but for
React-jscpod.Changelog:
[IOS] [FIXED] - Allow for consuming RCTImage in Swift codebase by enabling "Defines Module" option
Test Plan:
RNTester should build & run correctly