Fix RNTester hermesc build issue on iOS

[janicduplessis]

Summary:

I am not sure exactly why, but I've been getting this error when running RNTester on iOS, when it tries to build hermesc from source. We're clearing the env using env -i which seems to cause the issue. If I add PATH to the env we set then it builds fine.

++ hermesc_dir_path=/Users/janicduplessis/Developer/react-native/packages/rn-tester/Pods/hermes-engine/build_host_hermesc
++ shift
++ jsi_path=/Users/janicduplessis/Developer/react-native/packages/rn-tester/Pods/../../react-native/ReactCommon/jsi
+++ xcode-select -p
++ SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk
++ env -i SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk /opt/homebrew/bin/cmake -S /Users/janicduplessis/Developer/react-native/packages/rn-tester/Pods/hermes-engine -B /Users/janicduplessis/Developer/react-native/packages/rn-tester/Pods/hermes-engine/build_host_hermesc -DJSI_DIR=/Users/janicduplessis/Developer/react-native/packages/rn-tester/Pods/../../react-native/ReactCommon/jsi
CMake Error: CMake was unable to find a build program corresponding to "Unix Makefiles".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.
CMake Error: CMAKE_C_COMPILER not set, after EnableLanguage
CMake Error: CMAKE_CXX_COMPILER not set, after EnableLanguage
-- Configuring incomplete, errors occurred!
Command PhaseScriptExecution failed with a nonzero exit code

Changelog:

[INTERNAL] [FIXED] - Fix RNTester hermesc build issue on iOS

Test Plan:

Build RN tester locally

[cipolleschi]

Well spotted! The reason is a Cmake cache issue. Without the path I think it struggles to get the right version of CMake and when you change xcode with xcode-select, the caches might get poisoned.

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@cipolleschi merged this pull request in 1da608f.

[react-native-bot]

This pull request was successfully merged by @janicduplessis in 1da608f

^{When will my fix make it into a release? | How to file a pick request?}

[chrfalch]

@janicduplessis Does this work with cmake 4.x after the fix? It seems like a few of us had the same issue and after downgrading to cmake 3.x it worked.

[janicduplessis]

Yes I do have cmake 4, this might explain why not everyone has this issue.