[iOS][prebuild]: Added missing define to target .reactRuntime#52082
Closed
chrfalch wants to merge 1 commit into
Closed
[iOS][prebuild]: Added missing define to target .reactRuntime#52082chrfalch wants to merge 1 commit into
chrfalch wants to merge 1 commit into
Conversation
The target needs the HERMES_ENABLE_DEBUGGER flag in debug just like .reactHermes does. This commit fixes this by adding the define.
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
p: Expo
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in 560ac23. |
Collaborator
|
This pull request was successfully merged by @chrfalch in 560ac23 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The target needs the HERMES_ENABLE_DEBUGGER flag in debug just like .reactHermes does.
This commit fixes this by adding the define to the reactRuntime target.
Changelog:
[IOS] [FIXED] - Added HERMES_ENABLE_DEBUGGER to debug configuration for the reactRuntime target.
Test Plan:
Prebuild React Core