Add explicit Build Tools Version to RN Tester Android App Benchmark#52216
Closed
mojavad wants to merge 1 commit into
Closed
Add explicit Build Tools Version to RN Tester Android App Benchmark#52216mojavad wants to merge 1 commit into
mojavad wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cortinico merged this pull request in 35dba09. |
Collaborator
|
This pull request was successfully merged by @mojavad in 35dba09 When will my fix make it into a release? | How to file a pick request? |
1 similar comment
Collaborator
|
This pull request was successfully merged by @mojavad in 35dba09 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
After bumping to SDK version 36, the build process for Android was still pulling in SDK v35 unnecessarily. This PR fixes that issue.
Changelog:
[ANDROID] [FIXED] - Added explicit build tool version to RN Tester build.gradle to avoid automatic installation of Android SDK Build Tools.
Test Plan:
Tested in fork pipeline to ensure it's working correctly.
This is the logs from the pipeline before:
And this is after the fix:
