Ship the new React-Core-prebuilt.podspec in the package.json#52221
Closed
cipolleschi wants to merge 2 commits into
Closed
Ship the new React-Core-prebuilt.podspec in the package.json#52221cipolleschi wants to merge 2 commits into
cipolleschi wants to merge 2 commits into
Conversation
Summary: We were not handling the download of the XML properly. Using `Net::HTTP.get` will directly return the body and that won't let us check on the status code of the response. ## Changelog: [Internal] - use get_response instead of get when downloading the maven metadata Reviewed By: cortinico Differential Revision: D77216121
Summary: It is currently not possible to use prebuilds, because we are missing the `React-Core-prebuilt.podspec` from the npm package we publish. This change should fix it. ## Changelog: [iOS][Added] - Ship the `React-Core-prebuilt.podspec` in the package.json Differential Revision: D77223271
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77223271 |
Contributor
|
This pull request has been merged in 46b562b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
It is currently not possible to use prebuilds, because we are missing the
React-Core-prebuilt.podspecfrom the npm package we publish.This change should fix it.
Changelog:
[iOS][Added] - Ship the
React-Core-prebuilt.podspecin the package.jsonDifferential Revision: D77223271