Fix jumping talkback triggering scroll when reaching a view with accessibilityOrder#52231
Closed
jorge-cab wants to merge 2 commits into
Closed
Fix jumping talkback triggering scroll when reaching a view with accessibilityOrder#52231jorge-cab wants to merge 2 commits into
jorge-cab wants to merge 2 commits into
Conversation
Summary: Before, to disable views that were excluded from the order we were setting them to be not important for accessibility. This however breaks coopting behavior of parent views, because parent views will not announce content descriptions of children that are not important for accessibility. Instead of disabling by setting `important for accessibility = no` now we just set `isFocusable = false` which disables focusing but still allows parent views to coopt We also add functionality to restore view focusability when enabling disabling screen readers since `isFocusable` changes keyboard focusability and when screen readers are disabled we don't want to change it. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D76745057
…ssibilityOrder Summary: Not calling `super.onInitializeAccessibilityNodeInfo` on the host view with accessibilityOrder prevents setting proper dimensions for the node that backs the view which leads TalkBack to trigger scrolling when under a ScrollVIew. We still need the host's node to not be accessible so we still set it to not be focusable and not have a content description since this should be handled by the virtual views Reviewed By: joevilches Differential Revision: D77180494
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77180494 |
Contributor
|
This pull request has been merged in a82b5ac. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Not calling
super.onInitializeAccessibilityNodeInfoon the host view with accessibilityOrder prevents setting proper dimensions for the node that backs the view which leads TalkBack to trigger scrolling when under a ScrollVIew.We still need the host's node to not be accessible so we still set it to not be focusable and not have a content description since this should be handled by the virtual views
Reviewed By: joevilches
Differential Revision: D77180494