Use RegExp instead of micromatch #52234
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Changelog: [Internal] Build fantom_tester for OSS Differential Revision: D76928253
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77241819 |
Summary: Pull Request resolved: facebook#52234 Changelog: [Internal] Use raw regex instead of micromatch as it depends on node imports. Differential Revision: D77241819
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77241819 |
andrewdacenko
force-pushed
the
export-D77241819
branch
from
2240aa2 to
514fa30
Compare
Contributor
|
This pull request has been merged in 0b4429a. |
Collaborator
|
This pull request was successfully merged by @andrewdacenko in 0b4429a When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Use raw regex instead of micromatch as it depends on node imports.
Differential Revision: D77241819