Add codegen for PointPrimitive prop type diffing#52238
Closed
lenaic wants to merge 2 commits into
Closed
Conversation
added 2 commits
June 24, 2025 15:53
Summary: For array props conversion following later in this stack, each type should have a toDynamic conversion available that can be called upon to convert all supported types to a `folly::dynamic` result. This diff adds the toDynamic conversion function for `ImageSource` Changelog: [Internal] Differential Revision: D77234063
Summary: Add prop diffing codegen for `PointPrimitive` prop type by adding a `toDynamic` conversion for the struct and the prop diffing conditional result update. The addition of the `toDynamic` function will allow for converting the type when used in array and object types. Changelog: [Internal] Differential Revision: D77234062
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77234062 |
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
Jun 25, 2025
Summary: Add prop diffing codegen for `PointPrimitive` prop type by adding a `toDynamic` conversion for the struct and the prop diffing conditional result update. The addition of the `toDynamic` function will allow for converting the type when used in array and object types. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D77234062
Contributor
|
This pull request has been merged in 9b82e70. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add prop diffing codegen for
PointPrimitiveprop type by adding atoDynamicconversion for the struct and the prop diffing conditional result update.The addition of the
toDynamicfunction will allow for converting the type when used in array and object types.Changelog: [Internal]
Differential Revision: D77234062