VirtualView: Minimize Events w/ Render State#52245
Closed
yungsters wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77271865 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77271865 |
yungsters
force-pushed
the
export-D77271865
branch
from
35779ea to
01e6b11
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77271865 |
yungsters
force-pushed
the
export-D77271865
branch
from
01e6b11 to
233be4e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77271865 |
yungsters
force-pushed
the
export-D77271865
branch
from
233be4e to
8c80350
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77271865 |
yungsters
force-pushed
the
export-D77271865
branch
from
8c80350 to
76dfa5d
Compare
Summary: Pull Request resolved: facebook#52245 Changes `VirtualView` to avoid dispatching redundant mode change events by reading the last committed `renderState` to determine whether the desired render state is already in effect. This enables `VirtualView` to avoid dispatching synchronous `Visible` mode change events when a previous `Prerender` mode change event has already been committed. Changelog: [Internal] Reviewed By: lunaleaps Differential Revision: D77271865
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77271865 |
yungsters
force-pushed
the
export-D77271865
branch
from
76dfa5d to
103f387
Compare
Contributor
|
This pull request has been merged in 08a59c5. |
Collaborator
|
This pull request was successfully merged by @yungsters in 08a59c5 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changes
VirtualViewto avoid dispatching redundant mode change events by reading the last committedrenderStateto determine whether the desired render state is already in effect.This enables
VirtualViewto avoid dispatching synchronousVisiblemode change events when a previousPrerendermode change event has already been committed.Changelog:
[Internal]
Differential Revision: D77271865