[ios][prebuild] Refactored how we create umbrella, modulemap and header files #52286
+567
−320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make sure we expose all the swift features that we should, we expose and declare a variable from React_RCTAppDelegate
To make sure we are exposing the same public API to swift as without prebuilt, this commit changes the follow: - ModuleMap / Umbrella file is generated from template, not dynamically to align with non-prebuilt (cocoapods) - Headers are extracted by reading from podspec files and expanding their globs. This is now easy since we can use the podspec_sources function to look for file globs.
Headers for umbrella/module maps are moved into headers.js
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
p: Expo
cipolleschi
approved these changes
Jun 26, 2025
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
thanks for working on this!
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in 47b2fe4. |
Collaborator
|
This pull request was successfully merged by @chrfalch in 47b2fe4 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
To make sure we are exposing the same public API to swift as without prebuilt, this commit changes the follow:
Changelog:
[IOS][FIXED] - refactored header/umbrella/modulemap generation for prebuild
Test Plan: