make VirtualView hidden when it is not visible on screen #52294
Closed
+41
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Views that are hidden provide couple perf benefits: - The layer is skipped during hit-testing, so the view no longer receives touches. - Compositing work for the layer is skipped, so nothing is uploaded to the GPU for that view. Note, VirtualView still occupies space in memory and because this is infinite list and its numbers will grow unbounded. In this diff, hidden = YES is only set when VirtualView does not participate in accessibility features. Reviewed By: yungsters Differential Revision: D76597973
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76597973 |
Contributor
|
This pull request has been merged in e3f029f. |
Collaborator
|
This pull request was successfully merged by @sammy-SC in e3f029f When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Views that are hidden provide couple perf benefits:
Note, VirtualView still occupies space in memory and because this is infinite list and its numbers will grow unbounded.
In this diff, hidden = YES is only set when VirtualView does not participate in accessibility features.
Reviewed By: yungsters
Differential Revision: D76597973