Remove HTTP keepAliveTimeout workaround not needed since Node.js 12#52561
Closed
robhogan wants to merge 1 commit into
Closed
Remove HTTP keepAliveTimeout workaround not needed since Node.js 12#52561robhogan wants to merge 1 commit into
robhogan wants to merge 1 commit into
Conversation
Summary: The removed code comment is pretty clear that this workaround is in place for a specific bug, which was closed in a Node.js 8.x minor: nodejs/node#13391 A related issue descibed a problem that still existed in Node 10: nodejs/node#27363 Subsequent comments reporting problems with newer Node.js versions all seem to relate to mismatched configuration with load balancers, not directly relevant to Metro. Reproducers for the original bugs no longer repro on new Node.js (tested with 22.14), so I think it's safe to conclude this is fixed. Changelog: [Internal] Differential Revision: D78158427
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78158427 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 11, 2025
…52561) Summary: The removed code comment is pretty clear that this workaround is in place for a specific bug, which was closed in a Node.js 8.x minor: nodejs/node#13391 A related issue descibed a problem that still existed in Node 10: nodejs/node#27363 Subsequent comments reporting problems with newer Node.js versions all seem to relate to mismatched configuration with load balancers, not directly relevant to Metro. Reproducers for the original bugs no longer repro on new Node.js (tested with 22.14), so I think it's safe to conclude this is fixed. Changelog: [Internal] Differential Revision: D78158427
Contributor
|
This pull request has been merged in bb3ef78. |
Collaborator
|
This pull request was successfully merged by @robhogan in bb3ef78 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The removed code comment is pretty clear that this workaround is in place for a specific bug, which was closed in a Node.js 8.x minor: nodejs/node#13391
A related issue descibed a problem that still existed in Node 10:
nodejs/node#27363
Subsequent comments reporting problems with newer Node.js versions all seem to relate to mismatched configuration with load balancers, not directly relevant to Metro.
Reproducers for the original bugs no longer repro on new Node.js (tested with 22.14), so I think it's safe to conclude this is fixed.
Changelog: [Internal]
Differential Revision: D78158427