Add new environment variables to force CI and debug C++#52776
Closed
rubennorte wants to merge 3 commits into
Closed
Add new environment variables to force CI and debug C++#52776rubennorte wants to merge 3 commits into
rubennorte wants to merge 3 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78801918 |
rubennorte
force-pushed
the
export-D78801918
branch
2 times, most recently
from
f776bc0 to
2934c7a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78801918 |
rubennorte
force-pushed
the
export-D78801918
branch
from
2934c7a to
7a0c5b8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78801918 |
rubennorte
force-pushed
the
export-D78801918
branch
from
7a0c5b8 to
7c59794
Compare
Summary: Changelog: [internal] Reported locations for errors in Fantom is wrong, because it seems it's not ignoring "infra" frames. This was caused by the `stack` property in `ErrorWithCustomBlame` being set on the error objects and shadowing the getter that removes the necessary frames. This fixes that by forcing that property to be deleted. Reviewed By: christophpurrer Differential Revision: D78747119
…ode (facebook#52759) Summary: Changelog: [internal] This introduces a new environment variable for Fantom to disable benchmarks (`FANTOM_FORCE_TEST_MODE`), without having to run in CI mode. Reviewed By: rshest Differential Revision: D78672864
Summary: Changelog: [internal] `FANTOM_FORCE_CI_MODE` is just an explicit way to indicate that we're on CI, so we'd run benchmarks in test mode, for example. `FANTOM_DEBUG_CPP` is just an alias for `FANTOM_ENABLE_CPP_DEBUGGING` which is unnecessarily long. Differential Revision: D78801918
rubennorte
force-pushed
the
export-D78801918
branch
from
7c59794 to
2dc72bd
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78801918 |
Contributor
|
This pull request has been merged in 130b46c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
FANTOM_FORCE_CI_MODEis just an explicit way to indicate that we're on CI, so we'd run benchmarks in test mode, for example.FANTOM_DEBUG_CPPis just an alias forFANTOM_ENABLE_CPP_DEBUGGINGwhich is unnecessarily long.Differential Revision: D78801918