Add 'testWithArg' to Fantom benchmarking API#52831
Closed
rshest wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78970312 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78970312 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78970312 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78970312 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78970312 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78970312 |
Summary: # Changelog [Internal] - The corresponding `testWithArg` API is similar to the existing `test` one for the Fantom benchmarks, except it would allow to run the same test several times in a parametrized manner, with the set of parameters specified as an array (for now, of numbers). This allows to easily implement testing patterns such as we have in a View benchmark test, whereas we have a mostly duplicated test body doing a similar thing with 100, 1000, 1500 view component instances etc. Reviewed By: rubennorte Differential Revision: D78970312
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78970312 |
Contributor
|
This pull request has been merged in c5bb31c. |
Collaborator
|
This pull request was successfully merged by @rshest in c5bb31c When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog
[Internal] -
The corresponding
testWithArgAPI is similar to the existingtestone for the Fantom benchmarks, except it would allow to run the same test several times in a parametrized manner, with the set of parameters specified as an array (for now, of numbers).This allows to easily implement testing patterns such as we have in a View benchmark test, whereas we have a mostly duplicated test body doing a similar thing with 100, 1000, 1500 view component instances etc.
Differential Revision: D78970312