Add details about undoing require() image sizing#5291
Merged
skevy merged 1 commit intofacebook:masterfrom Jan 13, 2016
olegbl:patch-1
Merged
Add details about undoing require() image sizing#5291skevy merged 1 commit intofacebook:masterfrom olegbl:patch-1
skevy merged 1 commit intofacebook:masterfrom
olegbl:patch-1
Conversation
It can be overridden with undefined to scale dynamically
Contributor
|
By analyzing the blame information on this pull request, we identified @frantic, @brentvatne and @vjeux to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
skevy
added a commit
that referenced
this pull request
Jan 13, 2016
Add details about undoing require() image sizing
Contributor
|
Sweet, thanks! Long term we could detect use of flex and width/hight on an element and warn the user |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can be overridden with undefined to scale dynamically