Skip to content

Static generators for Profile Trace Events#52915

Closed
hoxyq wants to merge 3 commits into
facebook:mainfrom
hoxyq:export-D78919220
Closed

Static generators for Profile Trace Events#52915
hoxyq wants to merge 3 commits into
facebook:mainfrom
hoxyq:export-D78919220

Conversation

@hoxyq
Copy link
Copy Markdown
Contributor

@hoxyq hoxyq commented Jul 30, 2025

Summary:

Changelog: [Internal]

This removes the use of PerformanceTracer instance in a serialization logic.

Differential Revision: D78919220

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 30, 2025
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D78919220

hoxyq added 2 commits July 30, 2025 05:58
Summary:
# Changelog: [Internal]

We can't rely on RuntimeExecutor to actually tell us what JavaScript thread number is. Although this would work correct in most of the cases, this is not the solution we should go with.

Instead, we should fetch a map <id, name> of threads from the Host. This is what we will lazily call at the start of the Trace. I will add later on top of the stack.

Differential Revision: D78990872
Summary:
# Changelog: [Internal]

Just an aliases for referencing these ids, instead of raw uint64_t.

Differential Revision: D78741191
@hoxyq hoxyq force-pushed the export-D78919220 branch from 1dd1e45 to 0254026 Compare July 30, 2025 13:04
Summary:
Pull Request resolved: facebook#52915

# Changelog: [Internal]

This removes the use of `PerformanceTracer` instance in a serialization logic.

Differential Revision: D78919220
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D78919220

@hoxyq hoxyq force-pushed the export-D78919220 branch from 0254026 to 5a57d8e Compare July 30, 2025 13:08
hoxyq added a commit to hoxyq/react-native that referenced this pull request Jul 31, 2025
Summary:

# Changelog: [Internal]

This removes the use of `PerformanceTracer` instance in a serialization logic.

Reviewed By: rubennorte

Differential Revision: D78919220
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 31, 2025
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in a8f6c96.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants