Implement maxDuration option for PerformanceTracer#52935
Closed
rubennorte wants to merge 5 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79340014 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79340014 |
rubennorte
force-pushed
the
export-D79340014
branch
from
750450b to
bb468c3
Compare
rubennorte
force-pushed
the
export-D79340014
branch
from
bb468c3 to
6011f83
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79340014 |
rubennorte
force-pushed
the
export-D79340014
branch
from
6011f83 to
3d6a243
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79340014 |
Differential Revision: D79271691
Differential Revision: D79271690
Differential Revision: D79271692
Differential Revision: D79340013
rubennorte
force-pushed
the
export-D79340014
branch
from
3d6a243 to
6003927
Compare
rubennorte
force-pushed
the
export-D79340014
branch
from
6003927 to
0690e8e
Compare
rubennorte
force-pushed
the
export-D79340014
branch
from
0690e8e to
9c83ecb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79340014 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79340014 |
rubennorte
force-pushed
the
export-D79340014
branch
from
9c83ecb to
6bdaf76
Compare
Summary: Pull Request resolved: facebook#52935 Changelog: [internal] This implements a new option for `PerformanceTracer::startTracing` to specify a maximum duration for the recording, keeping only the last record events. This will allow us to implement an "always-on" profiling mode for RN with a low overhead. In the future, we can extend this with a `maxBufferSize` option. See the comment in `PerformanceTracer.cpp` for implementation details. Reviewed By: hoxyq Differential Revision: D79340014
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79340014 |
rubennorte
force-pushed
the
export-D79340014
branch
from
6bdaf76 to
2ea1c0a
Compare
Contributor
|
This pull request has been merged in 707a863. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This implements a new option for
PerformanceTracer::startTracingto specify a maximum duration for the recording, keeping only the last record events.This will allow us to implement an "always-on" profiling mode for RN with a low overhead. In the future, we can extend this with a
maxBufferSizeoption.See the comment in
PerformanceTracer.cppfor implementation details.Differential Revision: D79340014