Disable LongTasksAPI on Github CI#53009
Closed
rubennorte wants to merge 2 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79510480 |
Summary: Changelog: [internal] Exposing this value so we can disable some tests in some scenarios in a following this. Reviewed By: cipolleschi Differential Revision: D79510481
Summary: Changelog: [internal] This disables the test for LongTasks API on Github CI as the execution speed there is unreliable and makes the current tests flaky. This happens because the test is timing dependent, but the alternative would be to mock some core behaviors that I think might be even worse. Reviewed By: cortinico Differential Revision: D79510480
rubennorte
force-pushed
the
export-D79510480
branch
from
a1a580b to
f852989
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79510480 |
Contributor
|
This pull request has been merged in b708d2d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This disables the test for LongTasks API on Github CI as the execution speed there is unreliable and makes the current tests flaky.
Differential Revision: D79510480