Make test for LongTasks API deterministic and re-enable on Github#53018
Closed
rubennorte wants to merge 4 commits into
Closed
Make test for LongTasks API deterministic and re-enable on Github#53018rubennorte wants to merge 4 commits into
rubennorte wants to merge 4 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79554724 |
rubennorte
force-pushed
the
export-D79554724
branch
from
f9f00a6 to
e2c6f78
Compare
rubennorte
force-pushed
the
export-D79554724
branch
from
e2c6f78 to
30cd550
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79554724 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79554724 |
rubennorte
force-pushed
the
export-D79554724
branch
2 times, most recently
from
7c8b7d9 to
7576938
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79554724 |
rubennorte
force-pushed
the
export-D79554724
branch
from
7576938 to
42dff87
Compare
Differential Revision: D79554726
Differential Revision: D79554725
Differential Revision: D79554723
rubennorte
force-pushed
the
export-D79554724
branch
2 times, most recently
from
1475192 to
54c3c7d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79554724 |
rubennorte
force-pushed
the
export-D79554724
branch
from
54c3c7d to
08d78c2
Compare
…cebook#53018) Summary: Pull Request resolved: facebook#53018 Changelog: [internal] This makes the test for LongTasks API use the new API for mocking timers in Fantom to make it deterministic, and re-enables it on Github. Reviewed By: rshest Differential Revision: D79554724
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79554724 |
rubennorte
force-pushed
the
export-D79554724
branch
from
08d78c2 to
04d8967
Compare
Contributor
|
This pull request has been merged in 2658e21. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This makes the test for LongTasks API use the new API for mocking timers in Fantom to make it deterministic, and re-enables it on Github.
Differential Revision: D79554724