Allow mocking HighResTimeStamp in debug builds#53020
Closed
rubennorte wants to merge 2 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79554725 |
rubennorte
force-pushed
the
export-D79554725
branch
from
e60ced6 to
ac41190
Compare
rubennorte
force-pushed
the
export-D79554725
branch
from
ac41190 to
f9946e2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79554725 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79554725 |
rubennorte
force-pushed
the
export-D79554725
branch
from
f9946e2 to
41cf083
Compare
rubennorte
force-pushed
the
export-D79554725
branch
from
41cf083 to
897be11
Compare
rubennorte
force-pushed
the
export-D79554725
branch
2 times, most recently
from
824ec21 to
adefb25
Compare
Summary: Changelog: [internal] Moving the logic to set the default value for `HighResTimeStamp` to a shared function, to simplify further changes. Reviewed By: rshest Differential Revision: D79554726
Summary: Changelog: [internal] This adds a new feature to `HighResTimeStamp` to set a custom timestamp provider for "now" that can be useful for testing, only in debug builds to avoid potentially regressing performance. Reviewed By: hoxyq, rshest Differential Revision: D79554725
rubennorte
force-pushed
the
export-D79554725
branch
from
adefb25 to
3f909d9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79554725 |
Contributor
|
This pull request has been merged in f1cf489. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This adds a new feature to
HighResTimeStampto set a custom timestamp provider for "now" that can be useful for testing, only in debug builds to avoid potentially regressing performance.Differential Revision: D79554725