Update InspectorNetworkReporter to avoid overhead for CDP-only methods#53022
Closed
huntie wants to merge 1 commit into
Closed
Update InspectorNetworkReporter to avoid overhead for CDP-only methods#53022huntie wants to merge 1 commit into
huntie wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78004462 |
facebook#53022) Summary: Following D77799617, D77927896, updates `InspectorNetworkReporter.kt` to check `isDebuggingEnabled` internally and avoid work/communication over the JNI layer — to minimise impact on the Android Network stack. Changelog: [Internal] Differential Revision: D78004462
huntie
force-pushed
the
export-D78004462
branch
from
a2db505 to
fd9a2ec
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78004462 |
Contributor
|
This pull request has been merged in ea50245. |
Collaborator
|
This pull request was successfully merged by @huntie in ea50245 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Following D77799617, D77927896, updates
InspectorNetworkReporter.ktto checkisDebuggingEnabledinternally and avoid work/communication over the JNI layer — to minimise impact on the Android Network stack.Changelog: [Internal]
Differential Revision: D78004462