Remove redundant methods to mock timers from PerformanceEntryReporter and NativePerformance#53028
Closed
rubennorte wants to merge 5 commits into
Closed
Remove redundant methods to mock timers from PerformanceEntryReporter and NativePerformance#53028rubennorte wants to merge 5 commits into
rubennorte wants to merge 5 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79557640 |
Differential Revision: D79554726
Differential Revision: D79554725
Differential Revision: D79554723
Differential Revision: D79554724
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79557640 |
rubennorte
force-pushed
the
export-D79557640
branch
from
5f9b46a to
a51c252
Compare
… and NativePerformance (facebook#53028) Summary: Pull Request resolved: facebook#53028 Changelog: [internal] Now that we have mocking at a more fundamental level (`HighResTimeStamp` API) we can replace other timing mocks with that one. This does it for `PerformanceEntryReporter` and the `NativePerformance` module. Differential Revision: D79557640
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79557640 |
rubennorte
force-pushed
the
export-D79557640
branch
from
a51c252 to
19ab924
Compare
Contributor
|
This pull request has been merged in 7c1c833. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
Now that we have mocking at a more fundamental level (
HighResTimeStampAPI) we can replace other timing mocks with that one.This does it for
PerformanceEntryReporterand theNativePerformancemodule.Differential Revision: D79557640