Add test to ensure setUpDefaultReactNativeEnvironment does not access feature flags#53057
Closed
rubennorte wants to merge 2 commits into
Closed
Add test to ensure setUpDefaultReactNativeEnvironment does not access feature flags#53057rubennorte wants to merge 2 commits into
rubennorte wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79639890 |
rubennorte
force-pushed
the
export-D79639890
branch
from
0738066 to
ab852e1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79639890 |
rubennorte
force-pushed
the
export-D79639890
branch
from
ab852e1 to
97d49c9
Compare
…testing Differential Revision: D79639889
rubennorte
force-pushed
the
export-D79639890
branch
from
97d49c9 to
ca0480d
Compare
… feature flags (facebook#53057) Summary: Pull Request resolved: facebook#53057 Changelog: [internal] This adds a Fantom test to ensure that `setUpDefaultReactNativeEnvironment` doesn't read any feature flags. This prevents catching this as a runtime issue when the feature flag system complains that feature flags were accessed before being overridden, which always would happen if this module read any flags (as it runs before any product code that sets overrides). Reviewed By: rshest Differential Revision: D79639890
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79639890 |
rubennorte
force-pushed
the
export-D79639890
branch
from
ca0480d to
1e529cd
Compare
Contributor
|
This pull request has been merged in 5936f29. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This adds a Fantom test to ensure that
setUpDefaultReactNativeEnvironmentdoesn't read any feature flags. This prevents catching this as a runtime issue when the feature flag system complains that feature flags were accessed before being overridden, which always would happen if this module read any flags (as it runs before any product code that sets overrides).Differential Revision: D79639890