Cache result when RenderOutput::render() is called#53112
Closed
zeyap wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79737991 |
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Aug 6, 2025
Summary: ## Changelog: [Internal] [Changed] - Cache result when RenderOutput::render() is called Rreviously, root.getRenderedOutput in fantom doesn't really reflect the result of direct manipulation from native animated (see the test case added here). This stack is enabling it. * make RenderOutput an instance owned by TestMountingManager that can cache render result * why is this needed - native animation's direct manipulation should modify the render result (analog to directly manipulating host views on a platform) instead of props on a StubView * here i also make sure that `RenderOutput::render()` will only re calculate the render result for a tree after StubViewTree::mutate is called Differential Revision: D79737991
Summary: ## Changelog: [Internal] [Changed] - Cache result when RenderOutput::render() is called Rreviously, root.getRenderedOutput in fantom doesn't really reflect the result of direct manipulation from native animated (see the test case added here). This stack is enabling it. * make RenderOutput an instance owned by TestMountingManager that can cache render result * why is this needed - native animation's direct manipulation should modify the render result (analog to directly manipulating host views on a platform) instead of props on a StubView * here i also make sure that `RenderOutput::render()` will only re calculate the render result for a tree after StubViewTree::mutate is called Reviewed By: andrewdacenko Differential Revision: D79737991
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79737991 |
Contributor
|
This pull request has been merged in 5517c04. |
Collaborator
|
This pull request was successfully merged by @zeyap in 5517c04 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] [Changed] - Cache result when RenderOutput::render() is called
Rreviously, root.getRenderedOutput in fantom doesn't really reflect the result of direct manipulation from native animated (see the test case added here). This stack is enabling it.
RenderOutput::render()will only re calculate the render result for a tree after StubViewTree::mutate is calledDifferential Revision: D79737991