Skip to content

fix: fix a typo in the react_native_pods.rb file#53129

Closed
eliotfallon213 wants to merge 1 commit into
facebook:mainfrom
eliotfallon213:bugfix/pod-file-config-typo
Closed

fix: fix a typo in the react_native_pods.rb file#53129
eliotfallon213 wants to merge 1 commit into
facebook:mainfrom
eliotfallon213:bugfix/pod-file-config-typo

Conversation

@eliotfallon213
Copy link
Copy Markdown
Contributor

  • Switches fmt_config to fast_float_config so it matches what is used in the method

Summary:

When trying to use a forked version of the Pod it is not possible to set a new repo for Fast Float. This was caused by a typo in the method used to update the configuration of where to find the Pod.

Changelog:

[IOS] [FIXED] - Fixed variable naming error in set_fast_float_config method in react_native_pods.rb

Test Plan:

Add the line set_fast_float_config({:git => 'some-git-repo'}) to an application's Podfile

- Switches fmt_config to fast_float_config so it matches what is used in the method
@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Aug 7, 2025

Hi @eliotfallon213!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 7, 2025
@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Aug 7, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

1 similar comment
@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Aug 7, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Aug 7, 2025
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D79805939.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Aug 7, 2025
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cipolleschi merged this pull request in 327057f.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @eliotfallon213 in 327057f

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants