fix: fix a typo in the react_native_pods.rb file#53129
Conversation
- Switches fmt_config to fast_float_config so it matches what is used in the method
|
Hi @eliotfallon213! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
1 similar comment
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D79805939. |
|
@cipolleschi merged this pull request in 327057f. |
|
This pull request was successfully merged by @eliotfallon213 in 327057f When will my fix make it into a release? | How to file a pick request? |
Summary:
When trying to use a forked version of the Pod it is not possible to set a new repo for Fast Float. This was caused by a typo in the method used to update the configuration of where to find the Pod.
Changelog:
[IOS] [FIXED] - Fixed variable naming error in set_fast_float_config method in react_native_pods.rb
Test Plan:
Add the line
set_fast_float_config({:git => 'some-git-repo'})to an application's Podfile