native modules: Show message in redundant rejection redbox#53152
Closed
RSNara wants to merge 2 commits into
Closed
native modules: Show message in redundant rejection redbox#53152RSNara wants to merge 2 commits into
RSNara wants to merge 2 commits into
Conversation
…ok#53151) Summary: If the native module calls the resolve/reject, resolve/resolve, reject/resolve, reject/reject concurrently, the turbomodule infra could run into a null pointer exception. This diff mitigates that problem. Changelog: [iOS][Fixed] - Fix concurrent calls into resolve/reject inside native modules Differential Revision: D79824319
Summary: When a redundant reject is called, show the rejection message in the redbox. This can help us pin down the error we need to elminiate in production. Changelog: [Internal] Differential Revision: D79837541
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79837541 |
Contributor
|
This pull request has been merged in 7d6d0a7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When a redundant reject is called, show the rejection message in the redbox. This can help us pin down the error we need to elminiate in production.
Changelog: [Internal]
Differential Revision: D79837541