Skip to content

Fix retry logic in Fantom when requesting bundles from Metro #53161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rubennorte wants to merge 1 commit into from
Closed

Fix retry logic in Fantom when requesting bundles from Metro #53161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions private/react-native-fantom/runner/bundling.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ type BundleOptions = {
const PROJECT_ROOT = path.resolve(__dirname, '..', '..', '..');

export async function createBundle(options: BundleOptions): Promise<void> {
let bundleResult;
let bundleError;
let lastBundleResult;
let lastBundleError;

// Retry in case Metro hasn't seen the changes in the filesystem yet.
// TODO(T231910841): Remove this when Metro fixes consistency issues when resolving HTTP requests.
Expand All @@ -33,22 +33,32 @@ export async function createBundle(options: BundleOptions): Promise<void> {
await sleep(500);
}

lastBundleError = null;
lastBundleResult = null;

try {
bundleResult = await fetch(getBundleURL(options));
lastBundleResult = await fetch(getBundleURL(options));
} catch (e) {
bundleError = e;
lastBundleError = e;
}

attemps++;
} while (attemps < 3 && (bundleError || bundleResult?.status === 404));
} while (
attemps < 3 &&
(lastBundleError || lastBundleResult?.status === 404)
);

if (bundleError || bundleResult?.ok !== true) {
if (lastBundleError || lastBundleResult?.ok !== true) {
throw new Error(
`Failed to request bundle from Metro: ${bundleError?.message ?? (await bundleResult?.text()) ?? ''}`,
`Failed to request bundle from Metro: ${lastBundleError?.message ?? (await lastBundleResult?.text()) ?? ''}`,
);
}

await fs.promises.writeFile(options.out, await bundleResult.text(), 'utf8');
await fs.promises.writeFile(
options.out,
await lastBundleResult.text(),
'utf8',
);
}

export async function createSourceMap(options: BundleOptions): Promise<void> {
Expand Down
Loading