Basic Fantom Tests for Pressable#53181
Closed
CalixTang wants to merge 1 commit into
Closed
Conversation
Summary: Adds basic Fantom tests for the <Pressable> React Native component. Following T233710053, adds tests for some of the listed props and refs. Covered props: * children * disabled * onPress * style Ref: * Pressable is a Native Component and has the correct tag I did not cover the rest of the listed props due to Fantom not having suitable events to trigger to test them and/or inease of implementing functionality to do so. ## Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D79745215
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79745215 |
meta-cla
Bot
added
the
CLA Signed
Collaborator
|
This pull request was successfully merged by Calix Tang in e0ea781 When will my fix make it into a release? | How to file a pick request? |
Contributor
|
This pull request has been merged in e0ea781. |
|
Not very good, there are about 6-7 changes I would make. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds basic Fantom tests for the React Native component.
Following T233710053, adds tests for some of the listed props and refs.
Covered props:
Ref:
I did not cover the rest of the listed props due to Fantom not having suitable events to trigger to test them and/or inease of implementing functionality to do so.
Changelog:
[Internal]
Reviewed By: andrewdacenko
Differential Revision: D79745215