Allow custom factories for HTTP and WebSocket clients for DevTools#53200
Closed
rubennorte wants to merge 5 commits into
Closed
Allow custom factories for HTTP and WebSocket clients for DevTools#53200rubennorte wants to merge 5 commits into
rubennorte wants to merge 5 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79806934 |
rubennorte
force-pushed
the
export-D79806934
branch
from
4371263 to
ce75fd9
Compare
Differential Revision: D79804005
Differential Revision: D79804007
Differential Revision: D79804004
rubennorte
force-pushed
the
export-D79806934
branch
from
ce75fd9 to
2d9e460
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79806934 |
rubennorte
force-pushed
the
export-D79806934
branch
from
2d9e460 to
805230a
Compare
rubennorte
force-pushed
the
export-D79806934
branch
from
805230a to
14133f5
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79806934 |
…ablePackagerBundles Differential Revision: D79804006
rubennorte
force-pushed
the
export-D79806934
branch
from
14133f5 to
5ea271e
Compare
rubennorte
force-pushed
the
export-D79806934
branch
from
5ea271e to
080fcd4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79806934 |
…acebook#53200) Summary: Pull Request resolved: facebook#53200 Changelog: [internal] TSIA. This is necessary for Fantom to use real HTTP and WebSocket connections for DevTools, while still providing stubs for the runtime (the networking and websockets native modules provided to clients). If there are no specific factories for DevTools provided, we fall back to regular ones (keeping backwards compatibility). Reviewed By: rshest Differential Revision: D79806934
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79806934 |
rubennorte
force-pushed
the
export-D79806934
branch
from
080fcd4 to
86f856e
Compare
Contributor
|
This pull request has been merged in 4978385. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
TSIA. This is necessary for Fantom to use real HTTP and WebSocket connections for DevTools, while still providing stubs for the runtime (the networking and websockets native modules provided to clients).
If there are no specific factories for DevTools provided, we fall back to regular ones (keeping backwards compatibility).
Differential Revision: D79806934