Split ReactInstanceConfig.enableDebugging into enableInspector and enableDevMode#53201
Closed
rubennorte wants to merge 4 commits into
Closed
Split ReactInstanceConfig.enableDebugging into enableInspector and enableDevMode#53201rubennorte wants to merge 4 commits into
rubennorte wants to merge 4 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79804006 |
rubennorte
force-pushed
the
export-D79804006
branch
from
8d2afd4 to
96f2dc6
Compare
Differential Revision: D79804005
Differential Revision: D79804007
Differential Revision: D79804004
rubennorte
force-pushed
the
export-D79804006
branch
from
96f2dc6 to
09af6c1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79804006 |
rubennorte
force-pushed
the
export-D79804006
branch
from
09af6c1 to
54f0724
Compare
rubennorte
force-pushed
the
export-D79804006
branch
from
54f0724 to
b716328
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79804006 |
rubennorte
force-pushed
the
export-D79804006
branch
from
b716328 to
9b226ad
Compare
rubennorte
force-pushed
the
export-D79804006
branch
from
9b226ad to
67c16bb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79804006 |
…ableDevMode (facebook#53201) Summary: Pull Request resolved: facebook#53201 Changelog: [internal] This splits the `ReactHost` option `enableDebugging` into more granular options: - `enableInspector` which enables the connection with the inspector/debugger. - `enableDevMode` which enables the use of bundles from Metro, reloads, etc. This allows us to enable the inspector in Fantom without consuming bundles from Metro. This should be backwards compatible with existing apps. In the future, we should be able to inject custom `DevSupportManager` instances into the `ReactHost` so we can customize all options with any level of granularity (the same way we do on Android, for example). Reviewed By: rshest Differential Revision: D79804006
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79804006 |
rubennorte
force-pushed
the
export-D79804006
branch
from
67c16bb to
bcc6818
Compare
Contributor
|
This pull request has been merged in 42db2f8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This splits the
ReactHostoptionenableDebugginginto more granular options:enableInspectorwhich enables the connection with the inspector/debugger.enableDevModewhich enables the use of bundles from Metro, reloads, etc.This allows us to enable the inspector in Fantom without consuming bundles from Metro.
This should be backwards compatible with existing apps.
In the future, we should be able to inject custom
DevSupportManagerinstances into theReactHostso we can customize all options with any level of granularity (the same way we do on Android, for example).Differential Revision: D79804006