Connect debugger before loading bundle#53203
Closed
rubennorte wants to merge 3 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79804004 |
rubennorte
force-pushed
the
export-D79804004
branch
2 times, most recently
from
fe60e26 to
592776f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79804004 |
rubennorte
force-pushed
the
export-D79804004
branch
from
592776f to
0394304
Compare
rubennorte
force-pushed
the
export-D79804004
branch
from
0394304 to
87b569a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79804004 |
…3204) Summary: Changelog: [internal] This changes the logic to find an available port for Metro on Fantom to do this outside Metro. Before, we'd set `0` as the port for Metro to find an available port, but in a following change we'll need to know the port before calling into Metro. This allows that. Reviewed By: rshest Differential Revision: D79804005
Summary: Changelog: [internal] Just a minor refactor to follow the convention of prefixing Fantom-related globals and environment variables. Reviewed By: rshest Differential Revision: D79804007
Summary: Changelog: [internal] This makes ReactHost connect the inspector immediately after creating the instance, aligned with how we do it on Android, instead of doing it as part of loading a bundle. Reviewed By: rshest Differential Revision: D79804004
rubennorte
force-pushed
the
export-D79804004
branch
from
87b569a to
1c662a8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79804004 |
Contributor
|
This pull request has been merged in c2c2e6b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This makes ReactHost connect the inspector immediately after creating the instance, aligned with how we do it on Android, instead of doing it as part of loading a bundle.
Differential Revision: D79804004