Remove unused exception parameter from hermes/unittests/API/CDPAgentTest.cpp#53213
Closed
r-barnes wants to merge 1 commit into
Closed
Remove unused exception parameter from hermes/unittests/API/CDPAgentTest.cpp#53213r-barnes wants to merge 1 commit into
r-barnes wants to merge 1 commit into
Conversation
…est.cpp
Summary:
`-Wunused-exception-parameter` has identified an unused exception parameter. This diff removes it.
This:
```
try {
...
} catch (exception& e) {
// no use of e
}
```
should instead be written as
```
} catch (exception&) {
```
If the code compiles, this is safe to land.
Reviewed By: dtolnay
Differential Revision: D79968851
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79968851 |
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Aug 11, 2025
…est.cpp Summary: X-link: facebook/react-native#53213 `-Wunused-exception-parameter` has identified an unused exception parameter. This diff removes it. This: ``` try { ... } catch (exception& e) { // no use of e } ``` should instead be written as ``` } catch (exception&) { ``` If the code compiles, this is safe to land. Reviewed By: dtolnay Differential Revision: D79968851 fbshipit-source-id: 18f2e6861f099915b1aad6aba58217ba94eb10c8
Contributor
|
This pull request has been merged in 9eb90f8. |
Collaborator
|
This pull request was successfully merged by @r-barnes in 9eb90f8 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
-Wunused-exception-parameterhas identified an unused exception parameter. This diff removes it.This:
should instead be written as
If the code compiles, this is safe to land.
Reviewed By: dtolnay
Differential Revision: D79968851