Skip to content

Add accessibility props test to the <Text/> component #53218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rshest wants to merge 1 commit into from
+16 −10
Closed

Add accessibility props test to the <Text/> component #53218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions packages/react-native/Libraries/Text/__tests__/Text-itest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,14 @@
import '@react-native/fantom/src/setUpDefaultReactNativeEnvironment';

import type {Role} from '../../Components/View/ViewAccessibility';
import type {HostInstance} from 'react-native';
import type {AccessibilityProps, HostInstance} from 'react-native';

import ensureInstance from '../../../src/private/__tests__/utilities/ensureInstance';
import * as Fantom from '@react-native/fantom';
import * as React from 'react';
import {createRef} from 'react';
import {Text} from 'react-native';
import accessibilityPropsSuite from 'react-native/src/private/__tests__/utilities/accessibilityPropsSuite';
import ReactNativeElement from 'react-native/src/private/webapis/dom/nodes/ReactNativeElement';
import ReadOnlyText from 'react-native/src/private/webapis/dom/nodes/ReadOnlyText';

Expand Down Expand Up @@ -423,38 +424,38 @@ describe('<Text>', () => {

Fantom.runTask(() => {
root.render(
<Text style={{writingDirection: 'rtl'}}>dummy text</Text>,
<Text style={{writingDirection: 'rtl'}}>{TEST_TEXT}</Text>,
);
});

expect(
root.getRenderedOutput({props: ['writingDirection']}).toJSX(),
).toEqual(
<rn-paragraph writingDirection="rtl">dummy text</rn-paragraph>,
<rn-paragraph writingDirection="rtl">{TEST_TEXT}</rn-paragraph>,
);

Fantom.runTask(() => {
root.render(
<Text style={{writingDirection: 'ltr'}}>dummy text</Text>,
<Text style={{writingDirection: 'ltr'}}>{TEST_TEXT}</Text>,
);
});

expect(
root.getRenderedOutput({props: ['writingDirection']}).toJSX(),
).toEqual(
<rn-paragraph writingDirection="ltr">dummy text</rn-paragraph>,
<rn-paragraph writingDirection="ltr">{TEST_TEXT}</rn-paragraph>,
);

Fantom.runTask(() => {
root.render(
<Text style={{writingDirection: 'auto'}}>dummy text</Text>,
<Text style={{writingDirection: 'auto'}}>{TEST_TEXT}</Text>,
);
});

expect(
root.getRenderedOutput({props: ['writingDirection']}).toJSX(),
).toEqual(
<rn-paragraph writingDirection="auto">dummy text</rn-paragraph>,
<rn-paragraph writingDirection="auto">{TEST_TEXT}</rn-paragraph>,
);
});
});
Expand All @@ -468,7 +469,7 @@ describe('<Text>', () => {
const root = Fantom.createRoot();

Fantom.runTask(() => {
root.render(<Text ref={elementRef}>Some text</Text>);
root.render(<Text ref={elementRef}>{TEST_TEXT}</Text>);
});

const element = ensureInstance(elementRef.current, ReactNativeElement);
Expand All @@ -481,14 +482,14 @@ describe('<Text>', () => {
const root = Fantom.createRoot();

Fantom.runTask(() => {
root.render(<Text ref={elementRef}>Some text</Text>);
root.render(<Text ref={elementRef}>{TEST_TEXT}</Text>);
});

const element = ensureInstance(elementRef.current, ReactNativeElement);
expect(element.childNodes.length).toBe(1);

const textChild = ensureInstance(element.childNodes[0], ReadOnlyText);
expect(textChild.textContent).toBe('Some text');
expect(textChild.textContent).toBe(TEST_TEXT);
});

it('has text and element child nodes when nested', () => {
Expand Down Expand Up @@ -524,4 +525,9 @@ describe('<Text>', () => {
expect(secondChildText.textContent).toBe('also in bold');
});
});

component ComponentWithAccessibilityProps(...props: AccessibilityProps) {
return <Text {...props}>{TEST_TEXT}</Text>;
}
accessibilityPropsSuite(ComponentWithAccessibilityProps, false);
});
Loading