Improve benchmark comparison printout ("slower"->"faster")#53221
Closed
rshest wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80082134 |
rshest
force-pushed
the
export-D80082134
branch
from
aa35916 to
ca0c56f
Compare
rshest
force-pushed
the
export-D80082134
branch
from
ca0c56f to
58534cb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80082134 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80082134 |
rshest
force-pushed
the
export-D80082134
branch
from
58534cb to
1e52467
Compare
…53221) Summary: # Changelog: [Internal] - This changes the benchmark test results comparison print the results slightly differently, in particular it now uses the slowest result as a baseline and prints how much faster the other ones are (as opposed to printing "slower" previously). This arguably brings a more positive vibe when looking into the benchmark results :) Differential Revision: D80082134
rshest
force-pushed
the
export-D80082134
branch
from
1e52467 to
519d76e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80082134 |
Contributor
|
This pull request has been merged in 641a79d. |
Collaborator
|
This pull request was successfully merged by @rshest in 641a79d When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] -
This changes the benchmark test results comparison print the results slightly differently, in particular it now uses the slowest result as a baseline and prints how much faster the other ones are (as opposed to printing "slower" previously).
This arguably brings a more positive vibe when looking into the benchmark results :)
Differential Revision: D80082134