Support overriddenDuration in Fantom benchmarks#53250
Closed
rubennorte wants to merge 2 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80169515 |
rubennorte
changed the title
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80169515 |
rubennorte
force-pushed
the
export-D80169515
branch
from
23b57c9 to
e8c8b9b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80169515 |
rubennorte
force-pushed
the
export-D80169515
branch
from
e8c8b9b to
831ac9f
Compare
Differential Revision: D80169516
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80169515 |
rubennorte
force-pushed
the
export-D80169515
branch
from
831ac9f to
238f26b
Compare
Summary: Pull Request resolved: facebook#53250 Changelog: [internal] This updates the types for Fantom benchmarks to support the new `overriddenDuration` option from `tinybench`. It also exposes a new method in the benchmark namespace to access the same timestamp used in benchmarks. Reviewed By: rshest Differential Revision: D80169515
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80169515 |
rubennorte
force-pushed
the
export-D80169515
branch
from
238f26b to
f026bdb
Compare
Contributor
|
This pull request has been merged in e8bf982. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This updates the types for Fantom benchmarks to support the new overriddenDuration option from tinybench.
It also exposes a new method in the benchmark namespace to access the same timestamp used in benchmarks.
Differential Revision: D80169515