Fix maxLength default value when null is passed#53273
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80255637 |
cipolleschi
force-pushed
the
export-D80255637
branch
from
58c2e74 to
3778164
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80255637 |
cipolleschi
force-pushed
the
export-D80255637
branch
2 times, most recently
from
cb0bd96 to
0b99167
Compare
Summary: Pull Request resolved: facebook#53273 In [c5956da](facebook@c5956da) we landed a change of the default value of `maxLength`. While doing that, we missed the case where the app is explicitly passing `null` for a value for `maxLength`. When this happens, the props parsing was initializing the `maxLength` to 0, making not possible to input any value. This change fixes the issue by ensuring that the default value set when `null` is consistent with the default value when nothing is passed. ## Changelog: [iOS][Fixed] - Fixed TextInput behavior when `maxLength={null}` is passed Reviewed By: GijsWeterings Differential Revision: D80255637
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80255637 |
cipolleschi
force-pushed
the
export-D80255637
branch
from
0b99167 to
4ba19b9
Compare
Collaborator
|
This pull request was successfully merged by @cipolleschi in 56ad53c When will my fix make it into a release? | How to file a pick request? |
Contributor
|
This pull request has been merged in 56ad53c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In c5956da8c0 we landed a change of the default value of
maxLength.While doing that, we missed the case where the app is explicitly passing
nullfor a value formaxLength. When this happens, the props parsing was initializing themaxLengthto 0, making not possible to input any value.This change fixes the issue by ensuring that the default value set when
nullis consistent with the default value when nothing is passed.Changelog:
[iOS][Fixed] - Fixed TextInput behavior when
maxLength={null}is passedDifferential Revision: D80255637