Skip to content

Use string references in Fantom native module #53274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rubennorte wants to merge 1 commit into from
Closed

Use string references in Fantom native module #53274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions private/react-native-fantom/tester/src/NativeFantom.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ jsi::Object NativeFantom::getFabricUpdateProps(
void NativeFantom::enqueueNativeEvent(
jsi::Runtime& /*runtime*/,
std::shared_ptr<const ShadowNode> shadowNode,
std::string type,
const std::string& type,
const std::optional<folly::dynamic>& payload,
std::optional<RawEvent::Category> category,
std::optional<bool> isUnique) {
Expand Down Expand Up @@ -285,7 +285,7 @@ void NativeFantom::startJSSamplingProfiler(jsi::Runtime& /*runtime*/) {

void NativeFantom::stopJSSamplingProfilerAndSaveToFile(
jsi::Runtime& runtime,
std::string filePath) {
const std::string& filePath) {
auto* hermesRootAPI =
jsi::castInterface<hermes::IHermesRootAPI>(hermes::makeHermesRootAPI());
hermesRootAPI->disableSamplingProfiler();
Expand Down
4 changes: 2 additions & 2 deletions private/react-native-fantom/tester/src/NativeFantom.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ class NativeFantom : public NativeFantomCxxSpec<NativeFantom> {
void enqueueNativeEvent(
jsi::Runtime& runtime,
std::shared_ptr<const ShadowNode> shadowNode,
std::string type,
const std::string& type,
const std::optional<folly::dynamic>& payload,
std::optional<RawEvent::Category> category,
std::optional<bool> isUnique);
Expand Down Expand Up @@ -158,7 +158,7 @@ class NativeFantom : public NativeFantomCxxSpec<NativeFantom> {

void stopJSSamplingProfilerAndSaveToFile(
jsi::Runtime& runtime,
std::string filePath);
const std::string& filePath);

void setImageResponse(
jsi::Runtime& rt,
Expand Down
Loading