Apply better default options in benchmarks#53320
Closed
rubennorte wants to merge 4 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80405287 |
rubennorte
force-pushed
the
export-D80405287
branch
from
00c684c to
fcfc4f3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80405287 |
rubennorte
force-pushed
the
export-D80405287
branch
from
fcfc4f3 to
6edd809
Compare
Differential Revision: D80400268
Differential Revision: D80404121
Differential Revision: D80404378
rubennorte
force-pushed
the
export-D80405287
branch
from
6edd809 to
2037e61
Compare
Summary: Pull Request resolved: facebook#53320 Changelog: [internal] This improves the defaults the options related to minimum number of iterations and test duration in benchmarks. If you indicate a minimum duration, we set the minimum number of iterations so the duration is honored. We do the same if what's specified is the number of iterations. This is useful when you want to make sure all the tests in a benchmark suite use the same number of iterations without having to explicitly set the time to 0 in all of them. It also changes the default for warmup iterations to be just 1 (that's enough to load all modules and all the code into memory). Reviewed By: rshest Differential Revision: D80405287
rubennorte
force-pushed
the
export-D80405287
branch
from
2037e61 to
e307ef6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80405287 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80405287 |
rubennorte
force-pushed
the
export-D80405287
branch
from
e307ef6 to
eba5d6e
Compare
Contributor
|
This pull request has been merged in 6b4af38. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This improves the defaults the options related to minimum number of iterations and test duration in benchmarks.
If you indicate a minimum duration, we set the minimum number of iterations so the duration is honored. We do the same if what's specified is the number of iterations.
This is useful when you want to make sure all the tests in a benchmark suite use the same number of iterations without having to explicitly set the time to 0 in all of them.
It also changes the default for warmup iterations to be just 1 (that's enough to load all modules and all the code into memory).
Differential Revision: D80405287