Improve typing of benchmark functions#53322
Closed
rubennorte wants to merge 2 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80404121 |
rubennorte
force-pushed
the
export-D80404121
branch
from
9bd0885 to
6a1b870
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80404121 |
rubennorte
force-pushed
the
export-D80404121
branch
from
6a1b870 to
709d9df
Compare
Differential Revision: D80400268
rubennorte
force-pushed
the
export-D80404121
branch
from
709d9df to
1e4913e
Compare
Summary: Pull Request resolved: facebook#53322 Changelog: [internal] This changes the types for benchmark functions to improve safety: 1. It makes the return object be an object instead of an interface, to catch when `overriddenDuration` is misspelled. 2. It makes the function always synchronous, as asynchronous tests aren't supported in Fantom (even though they are in `tinybench`). Reviewed By: rshest Differential Revision: D80404121
rubennorte
force-pushed
the
export-D80404121
branch
from
1e4913e to
1d6032b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80404121 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80404121 |
rubennorte
force-pushed
the
export-D80404121
branch
from
1d6032b to
3e207c2
Compare
Contributor
|
This pull request has been merged in 6c37b5b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This changes the types for benchmark functions to improve safety:
overriddenDurationis misspelled.tinybench).Differential Revision: D80404121