Introduce hysteresis window#53345
Closed
lunaleaps wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80511627 |
lunaleaps
force-pushed
the
export-D80511627
branch
from
3d74399 to
b044262
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80511627 |
lunaleaps
force-pushed
the
export-D80511627
branch
from
b044262 to
e6bd7d4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80511627 |
lunaleaps
force-pushed
the
export-D80511627
branch
from
e6bd7d4 to
6828337
Compare
Summary: Changelog: [Internal] - Introduce hysteresis window that is nested between the prerender and hidden window sizes. Currently set to enlargening the prerender window by hysteresis ratio When a VirtualView intersects with the hysteresis window, it mode remains unchanged. This prevents us dispatch mode changes for things like overscroll. I put the hysteresis between prerender and hidden because we already avoid dispatching mode changes from visible -> prerender. For prerender -> visible, we use renderState Reviewed By: yungsters Differential Revision: D80511627
lunaleaps
force-pushed
the
export-D80511627
branch
from
6828337 to
bd25bc5
Compare
Contributor
|
This pull request has been merged in 792e450. |
Collaborator
|
This pull request was successfully merged by @lunaleaps in 792e450 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal] - Introduce hysteresis window that is nested between the prerender and hidden window sizes. Currently set to enlargening the prerender window by viewport height and width in each direction.
When a VirtualView intersects with the hysteresis window, it mode remains unchanged.
This prevents us dispatch mode changes for things like overscroll.
I put the hysteresis between prerender and hidden because we already avoid dispatching mode changes from visible -> prerender. For prerender -> visible, we use renderState
Differential Revision: D80511627