Remove Perf Monitor hooks from DevSupport API#53349
Closed
huntie wants to merge 2 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80464093 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80464093 |
huntie
force-pushed
the
export-D80464093
branch
from
079b002 to
91d9e7b
Compare
Summary: Pivots our display metric for the V2 Perf Monitor experiment by switching to Long Tasks. - Implements a new "__ReactNative__LongTask" metrics event (note: prefixed, since this sits outside the Web Vitals spec). Changelog: [Internal] Differential Revision: D79556595
huntie
force-pushed
the
export-D80464093
branch
from
91d9e7b to
7598383
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80464093 |
huntie
force-pushed
the
export-D80464093
branch
from
7598383 to
2eff55d
Compare
huntie
force-pushed
the
export-D80464093
branch
from
2eff55d to
964d329
Compare
Summary: Pull Request resolved: facebook#53349 Follows feedback on D78904767, refactoring how we pass data to `PerfMonitorOverlayViewManager` to avoid API additions on `DevSupport`. New interfaces under `com.facebook.react.devsupport.perfmonitor`: - `PerfMonitorUpdateListener` is implemented by the view class to receive updates from the C++ `HostTargetDelegate`. - `PerfMonitorInspectorTargetBinding` exposes an API on `ReactHostInspectorTarget` to send CDP actions down to C++ (stub for now). - `PerfMonitorDevHelper` allows us to use the internal `ReactHostImplDevHelper` to expose the `ReactHostInspectorTarget` instance from the runtime. Changelog: [Internal] Reviewed By: cortinico, rshest Differential Revision: D80464093
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80464093 |
huntie
force-pushed
the
export-D80464093
branch
from
964d329 to
047d055
Compare
Contributor
|
This pull request has been merged in 3d1d81c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Follows feedback on D78904767, refactoring how we pass data to
PerfMonitorOverlayViewManagerto avoid API additions onDevSupport.New interfaces under
com.facebook.react.devsupport.perfmonitor:PerfMonitorUpdateListeneris implemented by the view class to receive updates from the C++HostTargetDelegate.PerfMonitorInspectorTargetBindingexposes an API onReactHostInspectorTargetto send CDP actions down to C++ (stub for now).PerfMonitorDevHelperallows us to use the internalReactHostImplDevHelperto expose theReactHostInspectorTargetinstance from the runtime.Changelog: [Internal]
Reviewed By: cortinico, rshest
Differential Revision: D80464093