Fix build race condition with preparePrefab missing 3p headers#53384
Closed
cortinico wants to merge 1 commit into
Closed
Fix build race condition with preparePrefab missing 3p headers#53384cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80695212 |
…ook#53384) Summary: Occasionally, the `preparePrefab` task might run before other tasks that are responsible of populating the 3p headers, such as `prepareNative3pDependencies`. This was evident in the latest nightly which is missing the fast_float headers in the Android prefab. Adding a dependsOn fixes it. Changelog: [Internal] [Changed] - Differential Revision: D80695212
cortinico
force-pushed
the
export-D80695212
branch
from
75a8e73 to
2b9d4a3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80695212 |
Contributor
|
This pull request has been merged in fbef891. |
Collaborator
|
This pull request was successfully merged by @cortinico in fbef891 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Occasionally, the
preparePrefabtask might run before other tasks thatare responsible of populating the 3p headers, such as
prepareNative3pDependencies.This was evident in the latest nightly which is missing the fast_float headers in the
Android prefab.
Adding a dependsOn fixes it.
Changelog:
[Internal] [Changed] -
Differential Revision: D80695212