Fix Crash when rendering Switch component#53393
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
Summary: When implementing the changes for the Switch component for iOS 26, I didn't realize that the code in [`RCTIntance.mm`](https://www.internalfb.com/code/fbsource/[a54514baccf4e1f828ef46af8180555754c405d8]/xplat/js/react-native-github/packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTInstance.mm?lines=344-375) was running behind a feature flag. This means that all the users not in the experiment where the feature flag is turned on will experience a crash as soon as they navigate to a React Native screen that contains a Switch. This change fixes the problem by adding a jump to the right queue and it also fixes a measurement issue with the Switch. ## Changelog: [iOS][Fixed] - Fixed a crash when rendering the Switch component Differential Revision: D80702245
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80702245 |
Contributor
|
This pull request has been merged in 28275a0. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in 28275a0 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When implementing the changes for the Switch component for iOS 26, I didn't realize that the code in
RCTIntance.mmwas running behind a feature flag.This means that all the users not in the experiment where the feature flag is turned on will experience a crash as soon as they navigate to a React Native screen that contains a Switch.
This change fixes the problem by adding a jump to the right queue and it also fixes a measurement issue with the Switch.
Changelog:
[iOS][Fixed] - Fixed a crash when rendering the Switch component
Differential Revision: D80702245