Remove dead Inspector.kt/JInspector.h/.cpp code#53403
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80711515 |
Summary: This code is Legacy and totally unused. It should be safe to remove it altogether. This class is public but no one is using it in OSS + no one should be using it, so I don't think we'll need the full deprecation cycle for it. Changelog: [Android] [Removed] - Removed unused `Inspector` public class from React Android Reviewed By: cipolleschi Differential Revision: D80711515
cortinico
force-pushed
the
export-D80711515
branch
from
4dc4094 to
b046d54
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80711515 |
Contributor
|
This pull request has been merged in cf52852. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This code is Legacy and totally unused. It should be safe to remove it altogether.
This class is public but no one is using it in OSS + no one should be using it, so I don't think we'll need the full deprecation cycle for it.
Changelog:
[Android] [Removed] - Removed unused
Inspectorpublic class from React AndroidReviewed By: cipolleschi
Differential Revision: D80711515