Drop mention of Chrome/Edge if standalone shell enabled

packages/debugger-shell/__tests__/__snapshots__/dotslash-test.js.snap

@@ -0,0 +1,33 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`prepareDebuggerShellFromDotSlashFile fails with the expected error message for a missing dotslash file 1`] = `
+Object {
+  "code": "unexpected_error",
+  "humanReadableMessage": "An unexpected error occured while installing the latest version of React Native DevTools. Using a fallback version instead.",
+  "verboseInfo": Any<String>,
+}
+`;
+
+exports[`prepareDebuggerShellFromDotSlashFile fails with the expected error message for missing platforms 1`] = `
+Object {
+  "code": "platform_not_supported",
+  "humanReadableMessage": "The latest version of React Native DevTools is not supported on this platform. Using a fallback version instead.",
+  "verboseInfo": Any<String>,
+}
+`;
+
+exports[`prepareDebuggerShellFromDotSlashFile scenarios requiring a local HTTP server fails with the expected error message for a corrupted tarball 1`] = `
+Object {
+  "code": "possible_corruption",
+  "humanReadableMessage": "Failed to verify the latest version of React Native DevTools. Using a fallback version instead. ",
+  "verboseInfo": Any<String>,
+}
+`;
+
+exports[`prepareDebuggerShellFromDotSlashFile scenarios requiring a local HTTP server fails with the expected error message for a network error 1`] = `
+Object {
+  "code": "likely_offline",
+  "humanReadableMessage": "Failed to download the latest version of React Native DevTools. Using a fallback version instead. Connect to the internet or check your network settings.",
+  "verboseInfo": Any<String>,
+}
+`;

packages/debugger-shell/__tests__/dotslash-file-simulating-data-corruption.jsonc

@@ -0,0 +1,59 @@
+#!/usr/bin/env dotslash
+
+{
+    "name": "React Native DevTools",
+    "platforms": {
+        "linux-aarch64": {
+            "size": 113510892,
+            "hash": "sha256",
+            "digest": "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855",
+            "providers": [
+                {
+                    "type": "http",
+                    "url": "http://$HOST:$PORT/corrupted.tar.gz"
+                }
+            ],
+            "format": "tar.gz",
+            "path": "React Native DevTools-linux-arm64/React Native DevTools"
+        },
+        "linux-x86_64": {
+            "size": 113243910,
+            "hash": "sha256",
+            "digest": "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855",
+            "providers": [
+                {
+                    "type": "http",
+                    "url": "http://$HOST:$PORT/corrupted.tar.gz"
+                }
+            ],
+            "format": "tar.gz",
+            "path": "React Native DevTools-linux-x64/React Native DevTools"
+        },
+        "macos-aarch64": {
+            "size": 108810433,
+            "hash": "sha256",
+            "digest": "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855",
+            "providers": [
+                {
+                    "type": "http",
+                    "url": "http://$HOST:$PORT/corrupted.tar.gz"
+                }
+            ],
+            "format": "tar.gz",
+            "path": "React Native DevTools.app/Contents/MacOS/React Native DevTools"
+        },
+        "macos-x86_64": {
+            "size": 113769989,
+            "hash": "sha256",
+            "digest": "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855",
+            "providers": [
+                {
+                    "type": "http",
+                    "url": "http://$HOST:$PORT/corrupted.tar.gz"
+                }
+            ],
+            "format": "tar.gz",
+            "path": "React Native DevTools.app/Contents/MacOS/React Native DevTools"
+        }
+    }
+}

packages/debugger-shell/__tests__/dotslash-file-simulating-network-error.jsonc

@@ -0,0 +1,59 @@
+#!/usr/bin/env dotslash
+
+{
+    "name": "React Native DevTools",
+    "platforms": {
+        "linux-aarch64": {
+            "size": 113510892,
+            "hash": "sha256",
+            "digest": "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855",
+            "providers": [
+                {
+                    "type": "http",
+                    "url": "https://$HOST:$PORT/does-not-exist"
+                }
+            ],
+            "format": "tar.gz",
+            "path": "React Native DevTools-linux-arm64/React Native DevTools"
+        },
+        "linux-x86_64": {
+            "size": 113243910,
+            "hash": "sha256",
+            "digest": "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855",
+            "providers": [
+                {
+                    "type": "http",
+                    "url": "https://$HOST:$PORT/does-not-exist"
+                }
+            ],
+            "format": "tar.gz",
+            "path": "React Native DevTools-linux-x64/React Native DevTools"
+        },
+        "macos-aarch64": {
+            "size": 108810433,
+            "hash": "sha256",
+            "digest": "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855",
+            "providers": [
+                {
+                    "type": "http",
+                    "url": "https://$HOST:$PORT/does-not-exist"
+                }
+            ],
+            "format": "tar.gz",
+            "path": "React Native DevTools.app/Contents/MacOS/React Native DevTools"
+        },
+        "macos-x86_64": {
+            "size": 113769989,
+            "hash": "sha256",
+            "digest": "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855",
+            "providers": [
+                {
+                    "type": "http",
+                    "url": "https://$HOST:$PORT/does-not-exist"
+                }
+            ],
+            "format": "tar.gz",
+            "path": "React Native DevTools.app/Contents/MacOS/React Native DevTools"
+        }
+    }
+}

packages/debugger-shell/__tests__/dotslash-file-with-missing-platforms.jsonc

@@ -0,0 +1,6 @@
+#!/usr/bin/env dotslash
+
+{
+    "name": "React Native DevTools",
+    "platforms": {}
+}

packages/debugger-shell/__tests__/dotslash-test.js

@@ -0,0 +1,139 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @flow strict-local
+ * @format
+ */
+
+const {
+  prepareDebuggerShellFromDotSlashFile,
+} = require('../src/node/private/LaunchUtils');
+const fs = require('fs').promises;
+const http = require('http');
+const os = require('os');
+const path = require('path');
+
+// The implementation of prepareDebuggerShellFromDotSlashFile relies on
+// details of DotSlash that are not guaranteed to be stable (support for
+// `dotslash -- fetch <file>`, certain strings being printed to stderr).
+// This (admittedly elaborate) test suite ensures we'll fail loudly if we
+// try to upgrade DotSlash to a version that breaks our assumptions.
+describe('prepareDebuggerShellFromDotSlashFile', () => {
+  test('fails with the expected error message for missing platforms', async () => {
+    const result = await prepareDebuggerShellFromDotSlashFile(
+      path.join(__dirname, 'dotslash-file-with-missing-platforms.jsonc'),
+    );
+    expect(result).toMatchSnapshot({
+      verboseInfo: expect.any(String),
+    });
+  });
+
+  test('fails with the expected error message for a missing dotslash file', async () => {
+    const result = await prepareDebuggerShellFromDotSlashFile(
+      path.join(__dirname, 'dotslash-file-that-does-not-exist.jsonc'),
+    );
+    expect(result).toMatchSnapshot({
+      verboseInfo: expect.any(String),
+    });
+  });
+
+  describe('scenarios requiring a local HTTP server', () => {
+    let server, scratchDir;
+
+    beforeEach(async () => {
+      scratchDir = await fs.mkdtemp(path.join(os.tmpdir(), 'dotslash-test-'));
+      server = http.createServer((request, response) => {
+        if (request.url === '/corrupted.tar.gz') {
+          response.writeHead(200, {'Content-Type': 'application/gzip'});
+          response.end(
+            'Hello, world!\n' + 'This simulated a corrupted tarball.',
+          );
+        } else {
+          response.writeHead(404);
+          response.end();
+        }
+      });
+      await new Promise((resolve, reject) => {
+        server.on('error', reject);
+        server.listen(0, 'localhost', () => {
+          server.removeListener('error', reject);
+          resolve();
+        });
+      });
+    });
+
+    afterEach(async () => {
+      await fs.rm(scratchDir, {recursive: true, force: true});
+      if (server.listening) {
+        await new Promise((resolve, reject) => {
+          server.close(error => {
+            if (error) {
+              reject(error);
+            } else {
+              resolve();
+            }
+          });
+        });
+      }
+    });
+
+    test('fails with the expected error message for a corrupted tarball', async () => {
+      const dotslashFileContents = injectHostPort(
+        await fs.readFile(
+          path.join(
+            __dirname,
+            'dotslash-file-simulating-data-corruption.jsonc',
+          ),
+          'utf8',
+        ),
+        server.address(),
+      );
+
+      await fs.writeFile(
+        path.join(scratchDir, 'dotslash-file.jsonc'),
+        dotslashFileContents,
+      );
+      const result = await prepareDebuggerShellFromDotSlashFile(
+        path.join(scratchDir, 'dotslash-file.jsonc'),
+      );
+      expect(result).toMatchSnapshot({
+        verboseInfo: expect.any(String),
+      });
+    });
+
+    test('fails with the expected error message for a network error', async () => {
+      const dotslashFileContents = injectHostPort(
+        await fs.readFile(
+          path.join(__dirname, 'dotslash-file-simulating-network-error.jsonc'),
+          'utf8',
+        ),
+        server.address(),
+      );
+
+      await fs.writeFile(
+        path.join(scratchDir, 'dotslash-file.jsonc'),
+        dotslashFileContents,
+      );
+      const result = await prepareDebuggerShellFromDotSlashFile(
+        path.join(scratchDir, 'dotslash-file.jsonc'),
+      );
+      expect(result).toMatchSnapshot({
+        verboseInfo: expect.any(String),
+      });
+    });
+  });
+});
+
+function injectHostPort(
+  dotslashFileContents: string,
+  address: net$Socket$address,
+) {
+  const host =
+    address.family === 'IPv6' ? `[${address.address}]` : address.address;
+  return dotslashFileContents
+    .replaceAll('$HOST', host)
+    .replaceAll('$PORT', address.port.toString());
+}

packages/debugger-shell/__tests__/electron-dependency-test.js

@@ -22,7 +22,7 @@ describe('Electron dependency', () => {
     // $FlowFixMe[untyped-import] - package.json is not typed
     const ourPackageJson = require('../package.json');
 
-    const declaredElectronVersion = ourPackageJson.dependencies.electron;
+    const declaredElectronVersion = ourPackageJson.devDependencies.electron;
     expect(declaredElectronVersion).toBeTruthy();
 
     // $FlowFixMe[untyped-import] - package.json is not typed

packages/debugger-shell/package.json

@@ -26,14 +26,20 @@
   },
   "license": "MIT",
   "engines": {
-    "node": ">= 20.19.4",
-    "electron": ">=37.2.6"
+    "node": ">= 20.19.4"
   },
   "dependencies": {
     "cross-spawn": "^7.0.6",
-    "electron": "37.2.6"
+    "fb-dotslash": "0.5.8"
   },
   "devDependencies": {
+    "electron": "37.2.6",
     "semver": "^7.1.3"
-  }
+  },
+  "files": [
+    "!**/__tests__/**",
+    "bin",
+    "dist",
+    "!src/electron"
+  ]
 }

packages/debugger-shell/src/node/__tests__/debugger-shell-test.js

@@ -0,0 +1,48 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @flow strict-local
+ * @format
+ * @oncall react_native
+ */
+
+const {unstable_spawnDebuggerShellWithArgs} = require('../../');
+
+describe('debugger-shell Node package', () => {
+  test('can spawn in detached+prebuilt mode without crashing', async () => {
+    await expect(
+      unstable_spawnDebuggerShellWithArgs(['--version'], {
+        flavor: 'prebuilt',
+        mode: 'detached',
+      }),
+    ).resolves.toBeUndefined();
+  });
+
+  // When running in the internal react-native-oss-js job, Electron isn't
+  // installed correctly (postinstall scripts don't run) but the internal
+  // `electron` workspace isn't available either. Detecting this dynamically
+  // weakens the test somewhat in environments where it *should* pass, but this
+  // is a dev-only feature anyway so this is fine.
+  if (isElectronInstalled()) {
+    test('can spawn in detached+dev mode without crashing', async () => {
+      await expect(
+        unstable_spawnDebuggerShellWithArgs(['--version'], {
+          flavor: 'dev',
+          mode: 'detached',
+        }),
+      ).resolves.toBeUndefined();
+    });
+  }
+});
+
+function isElectronInstalled() {
+  try {
+    require('electron');
+    return true;
+  } catch {
+    return false;
+  }
+}