JS: Upgrade to signedsource@2.0.0#53606
Closed
yungsters wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81723007 |
Summary:
Upgrades projects to `signedsource@2.0.0`, which includes a critical bug fix to the `isSigned` and `signFile` functions:
```lang=diff
isSigned(data) {
- return !PATTERN.exec(data);
+ return PATTERN.exec(data) != null;
},
```
Changelog:
[Internal]
Reviewed By: bvanderhoof
Differential Revision: D81723007
yungsters
force-pushed
the
export-D81723007
branch
from
dcbf33e to
c7e055b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81723007 |
Contributor
|
This pull request has been merged in a50ddf3. |
Collaborator
|
This pull request was successfully merged by @yungsters in a50ddf3 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Upgrades projects to
signedsource@2.0.0, which includes a critical bug fix to theisSignedandsignFilefunctions:Changelog:
[Internal]
Differential Revision: D81723007