Create function to create hardlink to header required to build React Native Core#53635
Closed
cipolleschi wants to merge 6 commits into
Closed
Create function to create hardlink to header required to build React Native Core#53635cipolleschi wants to merge 6 commits into
cipolleschi wants to merge 6 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81778464 |
cipolleschi
force-pushed
the
export-D81778464
branch
from
2127a95 to
9d484a0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81778464 |
cipolleschi
force-pushed
the
export-D81778464
branch
from
9d484a0 to
ac523ef
Compare
cortinico
approved these changes
Sep 9, 2025
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
cipolleschi
force-pushed
the
export-D81778464
branch
from
ac523ef to
722dca2
Compare
cipolleschi
force-pushed
the
export-D81778464
branch
from
67ac4ee to
153576a
Compare
Contributor
|
@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating diff in D81778464. |
cipolleschi
force-pushed
the
export-D81778464
branch
from
153576a to
1146376
Compare
Contributor
|
@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating diff in D81778464. |
cipolleschi
force-pushed
the
export-D81778464
branch
from
1146376 to
ce83367
Compare
Contributor
|
@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating diff in D81778464. |
Summary: This change adds a simple function that manages symlinks. This is used through the stack of changes to avoid code repetition. ## Context SwiftPM is very picky in how the header structure must be. In order to preserve the import/include statements as much as possible when building from source, we can recreate the header structure in a temporary folder inside the react-native package using symlinks. In this way, users can still modify the headers and build RNTester and HelloWorld using SwiftPM without breaking changes. ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D82202860
Summary: This change add a utility function to extract headers (both .h and .hpp) from a folder. It also allow to exclude some specific folders (e.g.: `tests`, non supported platforms, ...) ## Context SwiftPM is very picky in how the header structure must be. In order to preserve the import/include statements as much as possible when building from source, we can recreate the header structure in a temporary folder inside the react-native package using symlinks. In this way, users can still modify the headers and build RNTester and HelloWorld using SwiftPM without breaking changes. ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D82205692
…a destination path (facebook#53620) Summary: ## Context One of the quirk of SwiftPM is that the packages has to have access to the headers they need. Usually this is solved by properly setting the header_search_path. However, in SwiftPM, we are not allowed to use headers search path that escape the package itself (basically, header search path can't start with `../`). To work around this limitation we are recreating the correct Header structure by using hardlinks to the actual headers. ## Changed In this change we are adding an helper function that creates links between a source folder and a destination folder. ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D81778469
…ers in the ReactApple folder (facebook#53629) Summary: ## Context One of the quirk of SwiftPM is that the packages has to have access to the headers they need. Usually this is solved by properly setting the header_search_path. However, in SwiftPM, we are not allowed to use headers search path that escape the package itself (basically, header search path can't start with `../`). To work around this limitation we are recreating the correct Header structure by using hardlinks to the actual headers. ## Changed In this change we are adding a function to properly create the header structure for the headers in ReactApple that requires a special case. ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D81778471
…ers in the ReactCommon folder (facebook#53631) Summary: ## Context One of the quirk of SwiftPM is that the packages has to have access to the headers they need. Usually this is solved by properly setting the header_search_path. However, in SwiftPM, we are not allowed to use headers search path that escape the package itself (basically, header search path can't start with `../`). To work around this limitation we are recreating the correct Header structure by using hardlinks to the actual headers. ## Changed In this change we are adding an helper function that creates links for the ReactCommon folder that has a complex structure and complex mapping requirements ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D81778470
…Native Core (facebook#53635) Summary: ## Context One of the quirk of SwiftPM is that the packages has to have access to the headers they need. Usually this is solved by properly setting the header_search_path. However, in SwiftPM, we are not allowed to use headers search path that escape the package itself (basically, header search path can't start with `../`). To work around this limitation we are recreating the correct Header structure by using hardlinks to the actual headers. ## Changed In this change we did two things: 1. we move the helper functions to a headers-utils.js file (and the tests to the `headers-utils-test.js` file) 2. we added a function that coordinates the creation of the header links *and added tests for it) ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D81778464
cipolleschi
force-pushed
the
export-D81778464
branch
from
ce83367 to
d7ac40e
Compare
Contributor
|
@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating diff in D81778464. |
Contributor
|
This pull request has been merged in 6807231. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Context
One of the quirk of SwiftPM is that the packages has to have access to the headers they need. Usually this is solved by properly setting the header_search_path. However, in SwiftPM, we are not allowed to use headers search path that escape the package itself (basically, header search path can't start with
../).To work around this limitation we are recreating the correct Header structure by using hardlinks to the actual headers.
Changed
In this change we did two things:
headers-utils-test.jsfile)Changelog:
[Internal] -
Differential Revision: D81778464